Improve README file #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It's an update to the
README.mdfile. The most important change is inside "Login Implementation" section, in which I propose to use the existingGoTrueClientthat's insideSupabaseClientinstead of creating a new one (this is whatsupabase-jsdocs recommend here).The rest is just minor improvements.
What is the current behavior?
N/A
What is the new behavior?
N/A
Additional context
Hello team! I'm using your module for an iOS side project and when I set up everything to make my authentication work, I found that small inconsistency I explain above and I decided to open a PR to update it. Please let me know if there is something I didn't understand well. Happy to contribute and also thank you for this awesome Supabase client! 🙂